-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#181 %.f fails with unexpected placeholder #188
base: master
Are you sure you want to change the base?
Conversation
Please provide unit tests |
To be honest I do not know sprintf - what types of input are good to include in test? Can you guide me a little? Basicly I change how ".precision" is interpreted - from digit(s) to digit(s) or 0 - what would be enough coverage in unit tests for that? Idea 1 Idea 2 Idea 3 |
…if the period is specified without an explicit value for precision, 0 is assumed
Best tests I could think of added. |
Bump |
bump? |
Can't remember why but I think this PR fixed some issue on another repo. Test still not good enough? It's been months. |
alexei doesnt care apperantly |
The other repo/issue is fengari-lua/fengari#147 (still blocked on this, 5 years later). Just ran into this one myself. XD |
fix #181
change regex matching precision in order to reflect C documentation:
"if the period is specified without an explicit value for precision, 0 is assumed"