Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: dependencies management #125

Open
trollepierre opened this issue Mar 14, 2023 · 1 comment
Open

Bug: dependencies management #125

trollepierre opened this issue Mar 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@trollepierre
Copy link

Describe the bug
I think react and react-dom should not be dependencies of this Node utilities.

To Reproduce

  1. Install typescript-coverage-report install another repository, not using react.
  2. Run yarn why react
  3. react appears to be imported

=> Found "typescript-coverage-report#[email protected]"
info This module exists because "typescript-coverage-report" depends on it.
info Disk size without dependencies: "332KB"
info Disk size with unique dependencies: "520KB"
info Disk size with transitive dependencies: "600KB"
info Number of shared dependencies: 5

Expected behaviour
typescript-coverage-report should not depend on react, or react-dom or semantic-ui-react

Screenshots
Capture d’écran 2023-03-14 à 10 21 11

Environment

  • Tool version: 0.7.0
  • OS: Mac OSX
  • Node version: 18.14.2
  • Browser (if applicable): no

Additional context
Those dependencies should be devDependencies in my opinion.
The required package should go in peerDependencies
example of react package.json: https://github.com/facebook/react/blob/main/package.json

@trollepierre trollepierre added the help wanted Extra attention is needed label Mar 14, 2023
@alexcanessa
Copy link
Owner

Interesting @trollepierre.

The package uses React to build the outcome and I agree it could just be pure HTML, CSS, and JS really.
I'll add it to the backlog.

@alexcanessa alexcanessa added enhancement New feature or request and removed help wanted Extra attention is needed labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants