Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview does not work correctly with images on articles #406

Merged
merged 1 commit into from
May 4, 2023

Conversation

lauer
Copy link

@lauer lauer commented May 4, 2023

This fixes #405 but also following issues

#383
#388
#396
#389

Currently only tested on Redmine 4.1.7.stable

@lauer
Copy link
Author

lauer commented May 4, 2023

It does also work on Redmine 4.2.x
But it does not work in Redmine 5.x - but that should be solved in #401

@lauer
Copy link
Author

lauer commented May 4, 2023

It does also solve #351

@alexbevi alexbevi merged commit 8797fb6 into alexbevi:master May 4, 2023
@alexbevi
Copy link
Owner

alexbevi commented May 4, 2023

@lauer this looks reasonable. I haven't tested it but I'll merge and close the tickets you referenced.

@lauer
Copy link
Author

lauer commented May 4, 2023

Great thanks. I also found this fork, which has some nice improvements.
https://github.com/drakosu/redmine_knowledgebase

e.g. confirm on delete, which is actually quite nice to have :)

But his branch can't be merged automatically :/

@alexbevi
Copy link
Owner

alexbevi commented May 4, 2023

@lauer if you're interested in maintaining this plugin just shoot me an email ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview does not work correctly with images on articles
2 participants