-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement GPU Support #728
Implement GPU Support #728
Conversation
Solution: Implement GPU assignation feature that will be pass-though to QEmu VMs with native performance.
a9f85eb
to
24516a2
Compare
891ed73
to
60b2491
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## proto-add-gpu-listing #728 +/- ##
=========================================================
- Coverage 62.79% 62.46% -0.33%
=========================================================
Files 72 73 +1
Lines 6343 6424 +81
Branches 514 528 +14
=========================================================
+ Hits 3983 4013 +30
- Misses 2199 2249 +50
- Partials 161 162 +1 ☔ View full report in Codecov by Sentry. |
0c58cad
to
ba1fc9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already add a few comments and concerns. I haven't been able to test it fully yet.
aleph-vm
refuse to launch properly as it is missing migration for the newly added database column. This is going to be a problem in prod.- The test server I use at the moment don't have a GPU, it's going to be added on Thursday.
c9b717e
to
70b7390
Compare
6a12504
to
d919116
Compare
I have tested with the CRN Andres put a my disposal and it seems to be working |
5f2579a
to
11141af
Compare
Related Jira tickets : ALEPH-314
Self proofreading checklist
packaging/Makefile
How to test
Create a QEmu VM with assigned GPUs and check that you can use it inside the Qemu VM