Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ol qemu confidential controller #620

Merged
merged 10 commits into from
Jun 14, 2024

Conversation

olethanh
Copy link
Collaborator

@olethanh olethanh commented May 29, 2024

Add the Qemu confidential controler, and endpoints to retrieve the measurements.

Copy link
Member

@hoh hoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start !

I commented on simple stuff not to forget since the PR is still in Draft.

src/aleph/vm/controllers/configuration.py Show resolved Hide resolved
src/aleph/vm/controllers/qemu/instance.py Outdated Show resolved Hide resolved
src/aleph/vm/controllers/qemu_confidential/instance.py Outdated Show resolved Hide resolved
src/aleph/vm/orchestrator/views/operator.py Outdated Show resolved Hide resolved
@olethanh
Copy link
Collaborator Author

@hoh Thanks ! but I just opened it so we could sync with @nesitor, I will refactor the whole thing and improve the style then so no need to waste time in stylistic review for now

@olethanh olethanh force-pushed the ol-qemu-confidential-controller branch 2 times, most recently from 5bf2db8 to 0167528 Compare June 13, 2024 08:17
@olethanh olethanh changed the base branch from main to dev-confidential June 13, 2024 11:41
@olethanh olethanh marked this pull request as ready for review June 13, 2024 11:42
@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 48.86878% with 113 lines in your changes missing coverage. Please review.

Project coverage is 59.10%. Comparing base (84fec2e) to head (3bc1969).

Files Patch % Lines
...c/aleph/vm/hypervisors/qemu_confidential/qemuvm.py 31.25% 33 Missing ⚠️
src/aleph/vm/orchestrator/views/operator.py 33.33% 30 Missing ⚠️
...aleph/vm/controllers/qemu_confidential/instance.py 60.00% 24 Missing ⚠️
src/aleph/vm/controllers/qemu/client.py 55.55% 16 Missing ⚠️
src/aleph/vm/controllers/__main__.py 16.66% 4 Missing and 1 partial ⚠️
src/aleph/vm/models.py 50.00% 2 Missing and 1 partial ⚠️
src/aleph/vm/hypervisors/qemu/qemuvm.py 0.00% 1 Missing ⚠️
src/aleph/vm/orchestrator/run.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           dev-confidential     #620      +/-   ##
====================================================
- Coverage             59.30%   59.10%   -0.21%     
====================================================
  Files                    62       65       +3     
  Lines                  5588     5778     +190     
  Branches                618      627       +9     
====================================================
+ Hits                   3314     3415     +101     
- Misses                 2130     2217      +87     
- Partials                144      146       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nesitor nesitor requested review from hoh and nesitor June 13, 2024 15:34
Copy link
Member

@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave the tests and the refactor for a later step and continue advancing on that feature.

@olethanh olethanh force-pushed the ol-qemu-confidential-controller branch from 402601b to 3bc1969 Compare June 14, 2024 12:15
@olethanh olethanh merged commit 15d7565 into dev-confidential Jun 14, 2024
20 of 22 checks passed
@Psycojoker Psycojoker deleted the ol-qemu-confidential-controller branch July 24, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants