-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ol qemu confidential controller #620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start !
I commented on simple stuff not to forget since the PR is still in Draft.
5bf2db8
to
0167528
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-confidential #620 +/- ##
====================================================
- Coverage 59.30% 59.10% -0.21%
====================================================
Files 62 65 +3
Lines 5588 5778 +190
Branches 618 627 +9
====================================================
+ Hits 3314 3415 +101
- Misses 2130 2217 +87
- Partials 144 146 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave the tests and the refactor for a later step and continue advancing on that feature.
because of deps problem. Solution : upgrade aiohttp version
Co-authored-by: nesitor <[email protected]>
402601b
to
3bc1969
Compare
Add the Qemu confidential controler, and endpoints to retrieve the measurements.