Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor VMPool class #442

Closed
wants to merge 8 commits into from
Closed

Refactor VMPool class #442

wants to merge 8 commits into from

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Oct 23, 2023 •
edited
Loading

Fix: Refactor VMPool class to decouple it from orchestrator path

@nesitor nesitor requested a review from hoh October 23, 2023 11:48
@nesitor nesitor self-assigned this Oct 23, 2023
@nesitor nesitor marked this pull request as draft October 23, 2023 12:24
@nesitor nesitor marked this pull request as ready for review October 23, 2023 13:07
@nesitor nesitor changed the title Fix: Refactor VMPool class to decouple it from orchestrator path Refactor VMPool class Oct 23, 2023
hoh
hoh reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@hoh hoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, just 1 comment + move the pyproject.toml changes in another PR. Can you squash the commits in one with our git commit guidelines ?

src/aleph/vm/controllers/firecracker/snapshot_manager.py
snapshot_execution = SnapshotExecution(
scheduler=self._scheduler,
vm_hash=vm_hash,
execution=execution,
execution=vm,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this argument be renamed ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, because it's the vm execution, also the class name is AlephFirecrackerExecutable, so I think that the name is already well-defined.

@nesitor
Copy link
Member Author

nesitor commented Oct 23, 2023

Closed in favor: #444

@nesitor nesitor closed this Oct 23, 2023
@nesitor nesitor deleted the andrees-refactor-vm-pool branch October 23, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoh hoh hoh left review comments

Assignees

@nesitor nesitor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nesitor @hoh