Version 0.3, with refactoring #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hoh
force-pushed
the
version-0.3.0
branch
5 times, most recently
from
cf17b83 to
1ee2e42
Compare
This refactors the codebase in order to make it possile to "pip install" it from other projects and reuse its components. Based on the proposal on: https://community.aleph.im/t/aleph-vm-refactoring-proposal/84 ``` . ├── aleph │ └── vm │ ├── controller │ │ ├── firecracker │ │ │ ├── executable │ │ │ ├── instance │ │ │ └── program │ │ └── qemu │ ├── guest_api │ ├── metrics │ ├── orchestrator │ │ ├── network │ │ └── views │ ├── snapthots │ └── tests ├── examples ├── kernels ├── packaging └── runtimes ```
This adds a `pyproject.toml` file for pip, with dependencies and commands to test the software.
This checks for the presence of these commands when starting the service, and recommends a way to install them when available.
Solution: Handle that scenario and dismiss this specific error.
Use the opportunity to upgrade Kubo 21 -> 23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the work in progress for the code refactoring discussed on the community forum.
Checklist:
pyproject.tomlfilepip installworksSecond phase: