Skip to content

Commit

Permalink
Apply suggestions from code review from Laurent
Browse files Browse the repository at this point in the history
Co-authored-by: Bram <[email protected]>
  • Loading branch information
olethanh and Psycojoker committed Nov 20, 2024
1 parent b76e6e4 commit f1bad18
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Node
## 2. Install Aleph-VM from source

This method is not recommended, except for development and testing.
Read the installation document for the various components and the developer documentaation.
Read the installation document for the various components and the developer documentation.

1. Install the [VM-Connector](./vm_connector/README.md)
2. Install the [VM-Supervisor](src/aleph/vm/orchestrator/README.md).
Expand Down Expand Up @@ -62,8 +62,8 @@ To deploy aleph-vm for development on a remote server, we start with the Debian

The vm-connector need to run for aleph-vm to works, even when running py.test.

Unless your focus is on developing the VM-Connector, using the Docker image is easier.
See [VM-Connector README](./vm_connector/README.md) for more details.
Unless your focus is developing the VM-Connector, using the Docker image is easier.
See the [VM-Connector README](./vm_connector/README.md) for more details.

```shell
docker run -d -p 127.0.0.1:4021:4021/tcp --restart=always --name vm-connector alephim/vm-connector:alpha
Expand Down Expand Up @@ -111,7 +111,7 @@ Unless your focus is on developing the VM-Connector, using the Docker image is e
directly during development.

## Testing
see [Testinc doc](./TESTING.md)
See [Testinc doc](./TESTING.md)

# Architecture

Expand Down
2 changes: 1 addition & 1 deletion TESTING.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Testing aleph-vm

This procedure describes how to run tests on a dev system. See the dev setup section of the README first
This procedure describes how to run tests on a dev system. See the dev setup section of the README first.

Tests also run on GitHub Actions via [the following workflow](./.github/workflows/test-on-droplets-matrix.yml).

Expand Down

0 comments on commit f1bad18

Please sign in to comment.