file exists check for scp #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
For me the file exists did not seem to work properly as it was misclassifying all files as being non-existent, resulting in some unnecessary updating.
It seemed the original check, i.e. checking if the string equals "1" did always returned false. This PR replaces it with a check on just the first character.
The exact cause is unknown for me, but I assume some trailing characters exist by using chomp on a plain "1". Maybe some dependency has changed behavior. It's a bit unclear to me but in general I think this is more stable.
Ruby version:
ruby 2.6.6p146 (2020-03-31 revision 67876) [x64-mingw32]