Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator IDs should contain the actual options instance passed to the generator #223

Open
benkrikler opened this issue Aug 26, 2014 · 0 comments

Comments

@benkrikler
Copy link
Contributor

This was first mentioned on ticket #205, but if we stored the actual options in a generator then we could very easily implement methods to check if a generator was run with a specific option. All existing methods would be useable as is, since the generator's option string is created in the options class itself already.

If a generator is run with no options, and provides default values in this case, then currently the options class doesn't store the defualt value. We could change this behaviour so that if a default value is returned (since the requested option was specified) we create a key value pair as if the option had been specified in the config file.

Things that would need (re)implementing:

  • Getters for the value of the individual underlying options given to a generator.
  • Assigning / Constructing from a string would need to be re-interpreted to recreate an options instance.
  • If default options are used by a generator, add this into the options instance key-value map.
@benkrikler benkrikler added this to the Long Term milestone Aug 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant