Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback - Module 2 #148

Open
callummole opened this issue Nov 3, 2022 · 1 comment
Open

Feedback - Module 2 #148

callummole opened this issue Nov 3, 2022 · 1 comment

Comments

@callummole
Copy link

callummole commented Nov 3, 2022

Some notes taken during delivery: (@lukehare, anything to add?)

  • map is introduced before functions. (Re)Move it from the end of 2.0. Could also explain map as a lazy function
  • it was commented that 2.0.5 dictionary comprehensions was a lot, done quickly. Unpack it
  • Some people were finding comprehensions hard to parse. To make things more readable we could have some in the form:
[do something
for x in [x]
if x is y]
  • test course on windows machine before delivery.

  • There is not enough time to do all notebooks. suggested to relegate 2.5 + 2.7 to self-study, since they are examples that bring it all together.

    • [name=Ed] If anything this module could be split in two so there is plenty of time for exercises
  • On 2.7, foreshadow constructors at the beginning. It introduces classes by adding attributes outside the class definition. This was confusing for people, so it might be better to introduce constructors first. And say that 'btw, you can add additional attributes outside the class definition if you want'.

  • Person class is missing self.room = room

    • Weirdly this is in the Person definition at the end, must've got taken out at some point
  • math.__file__ isn't available on windows. Change for another method.

@callummole
Copy link
Author

I also have not seen a single module that has stuck to the time-budget specified in the course. Perhaps we should increase the estimated time so that people plan better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant