DEMetropolisZMLDA does not respect base_blocked

[mikkelbue]

The DEMetropolisZMLDA base sampler does not get the self.base_blocked argument in the initialiser, and always runs as blocked. Is this on purpose?

                if self.base_sampler == "Metropolis":
                    # MetropolisMLDA sampler in base level (level=0), targeting self.model_below
                    self.step_method_below = pm.MetropolisMLDA(
                        vars=vars_below,
                        proposal_dist=self.base_proposal_dist,
                        S=self.base_S,
                        scaling=self.base_scaling,
                        tune=self.tune,
                        tune_interval=self.base_tune_interval,
                        model=None,
                        mode=self.mode,
                        blocked=self.base_blocked,
                        **base_kwargs,
                    )
                else:
                    # DEMetropolisZMLDA sampler in base level (level=0), targeting self.model_below
                    self.step_method_below = pm.DEMetropolisZMLDA(
                        vars=vars_below,
                        S=self.base_S,
                        proposal_dist=self.base_proposal_dist,
                        lamb=self.base_lamb,
                        scaling=self.base_scaling,
                        tune=self.base_tune_target,
                        tune_interval=self.base_tune_interval,
                        tune_drop_fraction=self.base_tune_drop_fraction,
                        model=None,
                        mode=self.mode,
                        **base_kwargs,
                    )

[gmingas]

This was done on purpose as DEMetropolisZ is by default blocked. But I never tried to run it as compound, so it might be OK to actually allow the option (at the moment the docstring and documentation in notebooks all say that DEMetropolisZ in MLDA is used only as blocked)

[mikkelbue]

I will test it some more, and make sure it works. I don't think there is anything wrong with running DEMetropolisZ as CompoundStep, it's just a default option, not forced.