Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-portable flags in Makevars #140

Open
jack89roberts opened this issue Jun 1, 2022 · 2 comments
Open

Non-portable flags in Makevars #140

jack89roberts opened this issue Jun 1, 2022 · 2 comments
Labels

Comments

@jack89roberts
Copy link
Contributor

rcmdcheck complains about Makevars having non-portable flags/extensions:

❯ checking compilation flags in Makevars ... WARNING
  Non-portable flags in variable 'PKG_CPPFLAGS':
    -fno-fast-math -msse2 -mfpmath=sse -mstackrealign

❯ checking for GNU extensions in Makefiles ... WARNING
  Found the following file(s) containing GNU extensions:
    src/Makevars
  Portable Makefiles do not use GNU extensions such as +=, :=, $(shell),
  $(wildcard), ifeq ... endif, .NOTPARALLEL See section ‘Writing portable
  packages’ in the ‘Writing R Extensions’ manual.

https://github.com/alan-turing-institute/network-comparison/runs/6691885148?check_suite_focus=true

Kind of related to #137 (@andeElliott @ots22 )

@jack89roberts
Copy link
Contributor Author

@ots22 @andeElliott - do we actually need to append to PKG_CPPFLAGS in Makevars or is setting it as in 9f7453b fine?

@jack89roberts
Copy link
Contributor Author

though that only fixes the 2nd warning above, not the 1st

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant