New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMD tests did not break when C++ EMD function was broken #115

Open

martintoreilly opened this issue Sep 21, 2018 · 0 comments

Assignees

Labels

bug

Member

martintoreilly commented Sep 21, 2018

Add or amend tests for EMD that will fail if the C++ implementation is broken.

We made some serious typos when refactoring and didn't break any tests, so the existing ones are insufficient.

Consider

Using uniform and normal distributions where true EMD can be calculated from offset
Checking if the tests that do all-to-all comparison of the example random and virusppi networks add any value and remove if not (see Make tests take less time #90).

martintoreilly added the bug label

martintoreilly self-assigned this

martintoreilly mentioned this issue

Fast C++ EMD function #106

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment