New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overriden default settings #32

Open

arvydas opened this issue Mar 16, 2014 · 0 comments

arvydas commented Mar 16, 2014

The line 73 in jquery.maximage.js has an issue.

if (typeof settings == 'object' || settings === undefined) config = $.extend( $.fn.maximage.defaults, settings || {} );

It's supposed to be:

if (typeof settings == 'object' || settings === undefined) config = $.extend({}, $.fn.maximage.defaults, settings || {} );

because according to the jQuery docs http://api.jquery.com/jquery.extend/ the first parameter gets to be modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment