Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Trying to read metric from plugin that is undefined #331

Open
danielgsims opened this issue Dec 5, 2021 · 1 comment
Open

Bug: Trying to read metric from plugin that is undefined #331

danielgsims opened this issue Dec 5, 2021 · 1 comment

Comments

@danielgsims
Copy link

I am experiencing an edge case where I am trying to read Time to First Interaction, but do not have the EventTiming plugin.

https://github.com/akamai/boomerang/blob/master/plugins/continuity.js#L3369-L3376

In the above code, there is a path where fid is loaded from the externalMetrics while the EventTiming plugin is undefined or not enabled, but then ttfi tries to read from the EventTiming plugin while it is undefined, resulting in the error TypeError: Cannot read properties of undefined (reading 'metrics')

@bluesmoon
Copy link
Member

bluesmoon commented Dec 5, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants