-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix optimizing db calls (#24) #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you @TalupulaSahithi for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better.
Resolve the conflict |
Resolved the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TalupulaSahithi,
Thank you for your prompt work on this issue. I appreciate your dedication to the project.
I have reviewed your work, and I'm pleased to inform you that I have merged your pull request. Your changes looks fantastic, and it aligns perfectly with the project's design and usability goals. Great job!
If you have any more contributions or if there's anything else you'd like to work on in the future, please don't hesitate to let us know. Your efforts are valuable to the project's success.
Once again, thank you for your contribution! ❤️
Fixed issue #24
2.In borrowing service there is a function updateBookCopies , which checks book exists or not (if not throws exception) and update the bookCopies count(if exist).
-updateBookCopies is used by borrow/return functionalities in which borrow function already checks book exists or not (which making book existence check in updateBookCopies as redundancy).
-updated return functionality to check book exists or not.
-removed book check in updateBookCopies and updated parameter of int bookId to Optional book .
3.Corrected borrowing-api , "Pay Fine" endpoint as "/borrowings/{id}/pay"
(Encountered this while testing , as it is a small correction, updated it)
Tested after updating code.