Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There has a problem when the character “@” within password #40

Open
xzycn opened this issue Mar 21, 2018 · 1 comment
Open

There has a problem when the character “@” within password #40

xzycn opened this issue Mar 21, 2018 · 1 comment

Comments

@xzycn
Copy link

xzycn commented Mar 21, 2018

There has a problem when the character “@” within password, maybe we should make the regex pattern more compatible? :) Here is my solution:

parts = re.match('(\w+://)([^:]+?:.+@)?(.+)', line.strip())

instead of

parts = re.match('(\w+://)([^:]+?:[^@]+?@)?(.+)', line.strip())
xzycn pushed a commit to xzycn/scrapy-proxies that referenced this issue Mar 21, 2018
fixed aivarsk#40
0f8050b
aleroot pushed a commit to aleroot/scrapy-proxies that referenced this issue Mar 23, 2018
Fix @ sign not allowed in password field of proxy url(fixes aivarsk#40)
3ce09d5
@aleroot
Copy link

aleroot commented Mar 23, 2018

Included in my pull request to add compatibility with splash browser

@aleroot aleroot mentioned this issue Mar 23, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aleroot @xzycn