Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Fix hanging issue during cleanup #4

Open
aisouard opened this issue Mar 15, 2017 · 4 comments
Open

Windows: Fix hanging issue during cleanup #4

aisouard opened this issue Mar 15, 2017 · 4 comments
Assignees
@aisouard
Labels
bug
Milestone
1.0

Comments

@aisouard
Copy link
Owner

Appveyor is failing after running the tests, this is certainly due to the changes over there: eb9ea40
@aisouard aisouard added the bug label Mar 15, 2017
@aisouard aisouard added this to the 0.1.0 milestone Mar 15, 2017
aisouard added a commit that referenced this issue Mar 28, 2017
@aisouard
(#4): Remove network thread, set a dedicated thread under Windows
cb8cae8
aisouard added a commit that referenced this issue Mar 28, 2017
@aisouard
(#4): Set the current thread to the signaling one
73a2eaf
@aisouard aisouard self-assigned this Mar 28, 2017
@aisouard
Copy link
Owner Author

It's hanging again under OSX... https://travis-ci.org/aisouard/node-webrtc/jobs/216071123

@aisouard
Copy link
Owner Author

It comes from that line, https://github.com/aisouard/node-webrtc/blob/develop/src/globals.cc#L65

The current thread is set as the signaling one, but the signaling thread is used as the worker thread, I should pay more attention.

Testing under Windows before pushing again.

@aisouard
Copy link
Owner Author

The issue is way more complicated, it seems that Node is not really happy with ref counted objects.
Will be fixed tonight.

aisouard added a commit that referenced this issue Mar 29, 2017
@aisouard
(#4): Move PeerConnectionFactory initialization inside RTCPeerConnection
f32c851
@aisouard
Copy link
Owner Author

Travis got stuck on that one, but it seems fixed.
Will reopen if it happens again.

@aisouard aisouard reopened this Nov 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aisouard aisouard

Labels
bug
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@aisouard