Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage depot_tools as an external project #33

Closed
4 tasks done
aisouard opened this issue Mar 12, 2017 · 2 comments
Closed
4 tasks done

Manage depot_tools as an external project #33

aisouard opened this issue Mar 12, 2017 · 2 comments
Assignees
@aisouard
Labels
cmake enhancement
Milestone
1.0

Comments

@aisouard
Copy link
Owner

aisouard commented Mar 12, 2017 •
edited
Loading

First step for #30

  • Retrieve the depot_tools repository with CMake
  • Set the environment variable inside prefix.sh to disable auto-update
  • Use gclient to retrieve WebRTC with the desired commit / release branch head
  • Checkout depot_tools to a commit having the closest date with WebRTC's
@aisouard aisouard added this to the 0.1.0 milestone Mar 12, 2017
@aisouard aisouard self-assigned this Mar 12, 2017
@aisouard aisouard mentioned this issue Mar 12, 2017
Open
aisouard added a commit that referenced this issue Mar 18, 2017
@aisouard
Manage depot_tools, replace modules, remove Targets folder, fixes #33
b59291f
@aisouard
Copy link
Owner Author

Refactored a lot of code and files in b59291f.
depot_tools is managed until we set a DEPOT_TOOLS_PATH variable.
WebRTC is manually fetched and sync'd with the right depot_tools revision.
I was finally able to remove libwebrtc_add_command macros, the code is cleaner and more elegant.

@aisouard
Copy link
Owner Author

Fixed in the refactor-depot-tools branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aisouard aisouard

Labels
cmake enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@aisouard