Destination Azure Blob Storage: Fix overwrite mode #52610
+58
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
tryangul
reviewed
Jan 28, 2025
| // 2. We really should include the namespace in the blob name, but we currently don't... | ||
| // So current behavior is that if you have `public1.users` and `public2.users`, | ||
| // those files will probably conflict in some way which is undesired. | ||
| if (!blob.isDeleted() && blob.getName().startsWith(configuredStream.getStream().getName() + "/")) { |
There was a problem hiding this comment.
Is there any way to unit test this behavior?
There was a problem hiding this comment.
trying to figure that out :/ might need to write something into legacy DATs, which will be not very fun
There was a problem hiding this comment.
have a look at 0886140 ? It's modeled after the existing test stuff, which is doing something funky with an azure blob emulation container?
but it fails without the contains -> startsWith change, and passes afterward
edgao
force-pushed
the
edgao/azure_blob_fix
branch
from
0886140 to
e0a33ca
Compare
octavia-squidington-iii
added
the
area/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: https://airbytehq-team.slack.com/archives/C083T7SUR0D/p1738094057451909?thread_ts=1738087568.864109&cid=C083T7SUR0D
previously:
usersandfoo_users)*foo_users/*, then create a blobfoo_users/<timestamp>_0*users/*... including the file we just created for foo_usersThis PR (I think) fixes that behavior, so that setup for
usersonly touches files that actually belong to theusersstream.(also, add a comment, b/c this destination is doing some dumb things in general)