Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Zendesk Talk : Restore Unit Test #50956

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Source Zendesk Talk : Restore Unit Test #50956

wants to merge 9 commits into from

Conversation

topefolorunso
Copy link
Collaborator

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jan 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 7:53am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zendesk-talk labels Jan 6, 2025
@octavia-squidington-iv octavia-squidington-iv requested a review from a team January 6, 2025 23:00
@topefolorunso
Copy link
Collaborator Author

topefolorunso commented Jan 6, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (95a9d35)

@topefolorunso
Copy link
Collaborator Author

@ChristoGrab This connector and a couple of others require requests-mock library. I added it to pyproject.toml file which works locally but fails in CI.

natikgadzhi
natikgadzhi reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the feedback that unit tests do not import requests_mock — I'll take a look at why it's failing.

airbyte-integrations/connectors/source-zendesk-talk/unit_tests/pyproject.toml

[tool.poetry.dependencies]
python = "^3.10,<3.13"
airbyte-cdk = "6.10.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for tests only, but we should set ^6.10, not 6.10 specifically, so this can be updated automatically if/when needed.

@ChristoGrab
Copy link
Contributor

ChristoGrab commented Jan 28, 2025 •
edited
Loading

Looking into the issue with the import. I can reproduce the failure locally using airbyte-ci, likely a bug in the testing environment setup

Edit: The logic to set up test dependencies in the ManifestOnlyConnectorUnitTests class is likely being overriden by the parent class. Not an easy step to debug due to dagger exploding any time you modify an exec chain. Created an issue to track the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natikgadzhi natikgadzhi natikgadzhi left review comments

@ChristoGrab ChristoGrab Awaiting requested review from ChristoGrab

@DanyloGL DanyloGL Awaiting requested review from DanyloGL

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zendesk-talk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@topefolorunso @ChristoGrab @natikgadzhi @octavia-squidington-iii