-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to a prebuilt CocoaPod to keep example on one dependency manager #74
Comments
We just unified on Cocoapods internally, and we hadn't come up with a solution for pre-building yet. I'd absolutely be curious to see how we could pre-build dependencies via Cocoapods rather than Carthage. I'm going to label this as an "enhancement", and I'll assign it to you. Excited to see what you come up with! Please do let us know how you end up pre-building – it'd be amazing to use a Cocoapods post-install hook to pre-build, but I'm curious what you think is best 😄 |
I'm not sure I would pre-build, as Buck's cache should handle the build artifact caching, but this would be a use case to include a closed-source framework shipped by a vendor. |
Got it. That works for me too! |
There's probably a far-term enhancement where if you just keep precompiled things in /vendor, since Buck doesn't rely on Xcodeproj files at all and uses file paths you could actually use Swift Package Manager since it does the dependency resolution and then puts all the code in |
"Official" support: https://guides.cocoapods.org/plugins/pre-compiling-dependencies.html |
I just never got around to setting up a precompiled pod to get this going. If you've got a good example, it should be pretty straightforward to replace the Carthage implementation. |
Removing the assignment then. This issue is very much up-for-grabs 🙂 |
@dfed you can put it back :D |
Re-assigned! 😄 |
In the quest to figure out how to better handle precompiled frameworks, I pushed https://github.com/thedavidharris/PrebuiltDynamicPod/releases/tag/1.0 that should be a little easier to work with and test than AFNetworking. If you're interested in getting this to just use CocoaPods for everything (which is probably a more representative example?) I can look to get that in.
The text was updated successfully, but these errors were encountered: