Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate() fails unit-tests because of a failed assertion in StateEvaluator.evaluate() #643

Open
yamaking2 opened this issue Nov 18, 2024 · 0 comments

Comments

@yamaking2
Copy link

Describe the bug
When using unified-planning/engines/TimeTriggeredPlanValidator in unit-tests, a call to unified_planning/model/walkers/state_evaluator.py::StateEvaluator.evaluate() fails the assertion assert r.is_constant(). The following print shows {expression} {r} {r.is_constant()}:
image

Both expression and r are of type OperatorKind.EQUALS, and this is why the assertion fails. If we mock the function evaluate with:
image

the assertion now succeeds. This leads us to believe that r is not being properly evaluated, and we're not sure why.

Expected behavior
We expect there to be no errors raised in our valid PDDL plans.

Additional context
The same PDDL used to work fine, but now it doesn't. We are not sure when did this assertion start failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant