Style/efficiency: expects vs boolean expression at the end?

[eddiemundo]

I'm not sure whether things are evaluated call-by-value, call-by-need, or something else, and whether trying to short-circuit computations is a good idea. I prefer doing something like:

fn is_valid() -> Bool {
  let is_cond1 = {
    // expensive...
  }
  let is_cond2 = {
    // expensive...
  }
  let is_cond3 = {
    // expensive...
  }
  list.and([
    is_cond1,
    is_cond2,
    is_cond3,
  ])
}

but psychologically I'm worried that this is more efficient

fn is_valid() -> Bool {
  let is_cond1 = ...
  expect True = is_cond1
  let is_cond2 = ...
  expect True = is_cond2
  let is_cond3 = ...
  expect True = is_cond3
  True
}

Is there maybe a performance/style guide, or does this all compile to the same code?

[rvcas]

cc @MicroProofs

[MicroProofs]

I would do is_cond1 &&
is_cond2 &&
is_cond3