Bump ruff to v0.8

.github/system_tests/test_daemon.py

@@ -16,16 +16,6 @@
 import tempfile
 import time
 
-from aiida.common import StashMode, exceptions
-from aiida.engine import run, submit
-from aiida.engine.daemon.client import get_daemon_client
-from aiida.engine.persistence import ObjectLoader
-from aiida.engine.processes import CalcJob, Process
-from aiida.manage.caching import enable_caching
-from aiida.orm import CalcJobNode, Dict, Int, List, Str, load_code, load_node
-from aiida.orm.nodes.caching import NodeCaching
-from aiida.plugins import CalculationFactory, WorkflowFactory
-from aiida.workflows.arithmetic.add_multiply import add, add_multiply
 from workchains import (
     ArithmeticAddBaseWorkChain,
     CalcFunctionRunnerWorkChain,
@@ -39,6 +29,16 @@
     WorkFunctionRunnerWorkChain,
 )
 
+from aiida.common import StashMode, exceptions
+from aiida.engine import run, submit
+from aiida.engine.daemon.client import get_daemon_client
+from aiida.engine.persistence import ObjectLoader
+from aiida.engine.processes import CalcJob, Process
+from aiida.manage.caching import enable_caching
+from aiida.orm import CalcJobNode, Dict, Int, List, Str, load_code, load_node
+from aiida.orm.nodes.caching import NodeCaching
+from aiida.plugins import CalculationFactory, WorkflowFactory
+from aiida.workflows.arithmetic.add_multiply import add, add_multiply
 from tests.utils.memory import get_instances
 
 CODENAME_ADD = 'add@localhost'

.github/workflows/ci-code.yml

@@ -104,7 +104,7 @@ jobs:
         AIIDA_WARN_v3: 1
       # Python 3.12 has a performance regression when running with code coverage
       # so run code coverage only for python 3.9.
-      run: pytest -v tests -m 'not nightly' ${{ matrix.python-version == '3.9' && '--cov aiida' || '' }}
+      run: pytest tests -m 'not nightly' ${{ matrix.python-version == '3.9' && '--cov aiida' || '' }}
 
     - name: Upload coverage report
       if: matrix.python-version == 3.9 && github.repository == 'aiidateam/aiida-core'

.github/workflows/test-install.yml

@@ -18,6 +18,9 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
+env:
+  FORCE_COLOR: 1
+
 jobs:
 
   validate-dependency-specification:
@@ -229,7 +232,7 @@ jobs:
       env:
         AIIDA_TEST_PROFILE: test_aiida
         AIIDA_WARN_v3: 1
-      run: pytest --verbose tests -m 'not nightly'
+      run: pytest tests -m 'not nightly'
 
     - name: Freeze test environment
       run: pip freeze | sed '1d' | tee requirements-py-${{ matrix.python-version }}.txt

.molecule/default/files/polish/cli.py

@@ -14,6 +14,7 @@
 import time
 
 import click
+
 from aiida.cmdline.params import options, types
 from aiida.cmdline.utils import decorators
 

.pre-commit-config.yaml

@@ -37,16 +37,10 @@ repos:
     args: [--line-length=120, --fail-on-change]
 
 - repo: https://github.com/astral-sh/ruff-pre-commit
-  rev: v0.5.0
+  rev: v0.8.0
   hooks:
   - id: ruff-format
-    exclude: &exclude_ruff >
-      (?x)^(
-        docs/source/topics/processes/include/snippets/functions/parse_docstring_expose_ipython.py|
-        docs/source/topics/processes/include/snippets/functions/signature_plain_python_call_illegal.py|
-      )$
   - id: ruff
-    exclude: *exclude_ruff
     args: [--fix, --exit-non-zero-on-fix, --show-fixes]
 
 - repo: https://github.com/macisamuele/language-formatters-pre-commit-hooks

docs/source/howto/include/scripts/performance_benchmark_base.py

@@ -2,6 +2,7 @@
 """Script to benchmark the performance of the AiiDA workflow engine on a given installation."""
 
 import click
+
 from aiida.cmdline.params import options
 from aiida.cmdline.utils import decorators, echo
 

docs/source/internals/includes/snippets/api.py

@@ -1,10 +1,11 @@
 #!/usr/bin/env python
 import click
+from flask_restful import Resource
+
 from aiida import load_profile
 from aiida.restapi import common
 from aiida.restapi.api import AiidaApi, App
 from aiida.restapi.run_api import run_api
-from flask_restful import Resource
 
 
 class NewResource(Resource):

docs/source/topics/processes/include/snippets/serialize/run_workchain_serialize.py

@@ -1,7 +1,8 @@
 #!/usr/bin/env runaiida
-from aiida.engine import run
 from serialize_workchain import SerializeWorkChain
 
+from aiida.engine import run
+
 if __name__ == '__main__':
     print(run(SerializeWorkChain, a=1, b=1.2, c=True))
     # Result: {'a': 1, 'b': 1.2, 'c': True}

docs/source/topics/workflows/include/snippets/expose_inputs/complex_parent.py

@@ -1,6 +1,7 @@
-from aiida.engine import ToContext, WorkChain
 from child import ChildWorkChain
 
+from aiida.engine import ToContext, WorkChain
+
 
 class ComplexParentWorkChain(WorkChain):
     @classmethod

docs/source/topics/workflows/include/snippets/expose_inputs/run_complex.py

@@ -1,8 +1,9 @@
 #!/usr/bin/env runaiida
 
+from complex_parent import ComplexParentWorkChain
+
 from aiida.engine import run
 from aiida.orm import Bool, Float, Int
-from complex_parent import ComplexParentWorkChain
 
 if __name__ == '__main__':
     result = run(

docs/source/topics/workflows/include/snippets/expose_inputs/run_simple.py

@@ -1,8 +1,9 @@
 #!/usr/bin/env runaiida
 
+from simple_parent import SimpleParentWorkChain
+
 from aiida.engine import run
 from aiida.orm import Bool, Float, Int
-from simple_parent import SimpleParentWorkChain
 
 if __name__ == '__main__':
     result = run(SimpleParentWorkChain, a=Int(1), b=Float(1.2), c=Bool(True))

docs/source/topics/workflows/include/snippets/expose_inputs/simple_parent.py

@@ -1,6 +1,7 @@
-from aiida.engine import ToContext, WorkChain
 from child import ChildWorkChain
 
+from aiida.engine import ToContext, WorkChain
+
 
 class SimpleParentWorkChain(WorkChain):
     @classmethod

pyproject.toml

@@ -387,6 +387,10 @@ testpaths = [
 xfail_strict = true
 
 [tool.ruff]
+exclude = [
+  'docs/source/topics/processes/include/snippets/functions/parse_docstring_expose_ipython.py',
+  'docs/source/topics/processes/include/snippets/functions/signature_plain_python_call_illegal.py'
+]
 line-length = 120
 
 [tool.ruff.format]

src/aiida/brokers/rabbitmq/client.py

@@ -9,7 +9,7 @@
 if t.TYPE_CHECKING:
     import requests
 
-__all__ = ('RabbitmqManagementClient', 'ManagementApiConnectionError')
+__all__ = ('ManagementApiConnectionError', 'RabbitmqManagementClient')
 
 
 class ManagementApiConnectionError(AiidaException):

src/aiida/brokers/rabbitmq/utils.py

@@ -2,7 +2,7 @@
 
 from . import defaults
 
-__all__ = ('get_rmq_url', 'get_launch_queue_name', 'get_message_exchange_name', 'get_task_exchange_name')
+__all__ = ('get_launch_queue_name', 'get_message_exchange_name', 'get_rmq_url', 'get_task_exchange_name')
 
 
 def get_rmq_url(protocol=None, username=None, password=None, host=None, port=None, virtual_host=None, **kwargs):

src/aiida/cmdline/groups/dynamic.py

@@ -177,7 +177,7 @@ def list_options(self, entry_point: str) -> list:
             # ``typing.Union[str, None].__args__`` will return the tuple ``(str, NoneType)``. So to get the real type,
             # we simply remove all ``NoneType`` and the remaining type should be the type of the option.
             if hasattr(field_info.annotation, '__args__'):
-                args = list(filter(lambda e: e != type(None), field_info.annotation.__args__))
+                args = list(filter(lambda e: e is not type(None), field_info.annotation.__args__))
                 # Click parameters only support specifying a single type, so we default to the first one even if the
                 # pydantic model defines multiple.
                 field_type = args[0]

src/aiida/cmdline/params/arguments/__init__.py

@@ -31,14 +31,14 @@
     'NODE',
     'NODES',
     'OUTPUT_FILE',
-    'OverridableArgument',
     'PROCESS',
     'PROCESSES',
     'PROFILE',
     'PROFILES',
     'USER',
     'WORKFLOW',
     'WORKFLOWS',
+    'OverridableArgument',
 )
 
 # fmt: on

src/aiida/cmdline/params/arguments/main.py

@@ -15,29 +15,29 @@
 from .overridable import OverridableArgument
 
 __all__ = (
-    'PROFILE',
-    'PROFILES',
     'CALCULATION',
     'CALCULATIONS',
     'CODE',
     'CODES',
     'COMPUTER',
     'COMPUTERS',
-    'DATUM',
+    'CONFIG_OPTION',
     'DATA',
+    'DATUM',
     'GROUP',
     'GROUPS',
+    'INPUT_FILE',
+    'LABEL',
     'NODE',
     'NODES',
+    'OUTPUT_FILE',
     'PROCESS',
     'PROCESSES',
+    'PROFILE',
+    'PROFILES',
+    'USER',
     'WORKFLOW',
     'WORKFLOWS',
-    'INPUT_FILE',
-    'OUTPUT_FILE',
-    'LABEL',
-    'USER',
-    'CONFIG_OPTION',
 )
 
 

src/aiida/cmdline/params/options/__init__.py

@@ -38,8 +38,6 @@
     'COMPUTER',
     'COMPUTERS',
     'CONFIG_FILE',
-    'CallableDefaultOption',
-    'ConfigFileOption',
     'DATA',
     'DATUM',
     'DB_BACKEND',
@@ -69,14 +67,12 @@
     'INPUT_PLUGIN',
     'LABEL',
     'LIMIT',
-    'MultipleValueOption',
     'NODE',
     'NODES',
     'NON_INTERACTIVE',
     'OLDER_THAN',
     'ORDER_BY',
     'ORDER_DIRECTION',
-    'OverridableOption',
     'PAST_DAYS',
     'PAUSED',
     'PORT',
@@ -108,6 +104,10 @@
     'WAIT',
     'WITH_ELEMENTS',
     'WITH_ELEMENTS_EXCLUSIVE',
+    'CallableDefaultOption',
+    'ConfigFileOption',
+    'MultipleValueOption',
+    'OverridableOption',
     'active_process_states',
     'graph_traversal_rules',
     'valid_calc_job_states',

src/aiida/cmdline/params/options/main.py

@@ -81,8 +81,8 @@
     'ORDER_BY',
     'ORDER_DIRECTION',
     'OVERWRITE',
-    'PATH',
     'PAST_DAYS',
+    'PATH',
     'PAUSED',
     'PORT',
     'PREPEND_TEXT',

src/aiida/cmdline/params/types/computer.py

@@ -14,7 +14,7 @@
 from ...utils import decorators
 from .identifier import IdentifierParamType
 
-__all__ = ('ComputerParamType', 'ShebangParamType', 'MpirunCommandParamType')
+__all__ = ('ComputerParamType', 'MpirunCommandParamType', 'ShebangParamType')
 
 
 class ComputerParamType(IdentifierParamType):

src/aiida/cmdline/params/types/strings.py

@@ -12,7 +12,7 @@
 
 from click.types import StringParamType
 
-__all__ = ('EmailType', 'EntryPointType', 'HostnameType', 'NonEmptyStringParamType', 'LabelStringType')
+__all__ = ('EmailType', 'EntryPointType', 'HostnameType', 'LabelStringType', 'NonEmptyStringParamType')
 
 
 class NonEmptyStringParamType(StringParamType):

src/aiida/cmdline/utils/decorators.py

@@ -27,7 +27,7 @@
 
 DAEMON_NOT_RUNNING_DEFAULT_MESSAGE = 'daemon is not running'
 
-__all__ = ('with_dbenv', 'dbenv', 'only_if_daemon_running')
+__all__ = ('dbenv', 'only_if_daemon_running', 'with_dbenv')
 
 
 @decorator

src/aiida/cmdline/utils/echo.py

@@ -20,14 +20,14 @@
 CMDLINE_LOGGER = logging.getLogger('verdi')
 
 __all__ = (
-    'echo_report',
+    'echo_critical',
+    'echo_dictionary',
+    'echo_error',
     'echo_info',
+    'echo_report',
     'echo_success',
-    'echo_warning',
-    'echo_error',
-    'echo_critical',
     'echo_tabulate',
-    'echo_dictionary',
+    'echo_warning',
 )
 
 

src/aiida/common/__init__.py

@@ -25,6 +25,7 @@
 
 __all__ = (
     'AIIDA_LOGGER',
+    'TQDM_BAR_FORMAT',
     'AiidaException',
     'AttributeDict',
     'CalcInfo',
@@ -74,7 +75,6 @@
     'StashMode',
     'StorageMigrationError',
     'StoringNotAllowed',
-    'TQDM_BAR_FORMAT',
     'TestsNotAllowedError',
     'TransportTaskException',
     'UniquenessError',

src/aiida/common/datastructures.py

@@ -15,7 +15,7 @@
 
 from .extendeddicts import DefaultFieldsAttributeDict
 
-__all__ = ('StashMode', 'CalcJobState', 'CalcInfo', 'CodeInfo', 'CodeRunMode')
+__all__ = ('CalcInfo', 'CalcJobState', 'CodeInfo', 'CodeRunMode', 'StashMode')
 
 
 class StashMode(Enum):