Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe Github templates #46

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Describe Github templates #46

merged 2 commits into from
Oct 14, 2021

Conversation

pacospace
Copy link
Member

@pacospace pacospace commented Oct 13, 2021 •
edited
Loading

Signed-off-by: Francesco Murdaca [email protected]

Fixes: thoth-station/support#91

Related-To: #45

Describe Github templates
be4efef 
Signed-off-by: Francesco Murdaca <[email protected]>
@sesheta sesheta added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2021
@sesheta
Copy link
Contributor

sesheta commented Oct 13, 2021

Hi @pacospace. Thanks for your PR.

I'm waiting for a aicoe-aiops member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacospace
Copy link
Member Author

/assign @MichaelClifford

@pacospace pacospace mentioned this pull request Oct 13, 2021
Closed
@MichaelClifford
Copy link
Member

This looks good, but should we add the updated text to the issue templates themselves? That way the information persists and is presented to users before each issue is created. This repo outline readme is often overwritten once a project gets started and this info will no longer be visible to users.

@pacospace
Copy link
Member Author

This looks good, but should we add the updated text to the issue templates themselves? That way the information persists and is presented to users before each issue is created. This repo outline readme is often overwritten once a project gets started and this info will no longer be visible to users.

Yes definitely better to have it also there, I will add it in this PR, thanks @MichaelClifford

@pacospace pacospace force-pushed the describe-github-templates branch 3 times, most recently from ea6005d to 6f229bf Compare October 13, 2021 14:16
@pacospace
Copy link
Member Author

updated! @MichaelClifford please have a look!

@MichaelClifford
Copy link
Member

Thanks @pacospace
/approve

@pacospace
Copy link
Member Author

/assign @tumido
/assign @durandom

@MichaelClifford should we add more approvers/reviewers?

@MichaelClifford
Copy link
Member

I was just about to update the owners file @pacospace

tumido
tumido approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021
@sesheta
Copy link
Contributor

sesheta commented Oct 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MichaelClifford, tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2021
@sesheta sesheta removed the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021
@sesheta
Copy link
Contributor

sesheta commented Oct 14, 2021

New changes are detected. LGTM label has been removed.

Add Notes to issues
55decbe 
Signed-off-by: Francesco Murdaca <[email protected]>
@sesheta sesheta merged commit de4fcb2 into aicoe-aiops:master Oct 14, 2021
chauhankaranraj pushed a commit to aicoe-aiops/cookiecutter-data-science that referenced this pull request Oct 26, 2021
Add GH issue template decsriptions from project-template.
ff1bbe8 
This commit pulls in the changes in project-template from the
aicoe-aiops/project-template#46 PR.
Original author of the content of this PR is pacospace.

Co-authored-by: Francesco Murdaca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tumido tumido tumido approved these changes

@durandom durandom Awaiting requested review from durandom durandom is a code owner

Assignees

@durandom durandom

@MichaelClifford MichaelClifford

@tumido tumido

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More documentation for the template issues for tag releases and redelivering containers.
5 participants
@pacospace @sesheta @MichaelClifford @tumido @durandom