Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add support for custom inputs and outputs #145

Merged
merged 8 commits into from
Oct 4, 2024

Conversation

bpapaspyros
Copy link
Member

@bpapaspyros bpapaspyros commented Oct 2, 2024

Description

Reference the following PRs:

This PR solves the issue by providing compile-time type inference for C++ to allow for generic types to be handled properly, and similar (runtime) changes for python which mirrors the C++ version.

Review guidelines

Estimated Time of Review: 35 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@bpapaspyros bpapaspyros self-assigned this Oct 2, 2024
@domire8
Copy link
Member

domire8 commented Oct 3, 2024

For me, this feature is now complete and we can update issue, description and changelog and then expect final reviews

@domire8 domire8 closed this Oct 3, 2024
@domire8 domire8 reopened this Oct 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
@bpapaspyros bpapaspyros marked this pull request as ready for review October 4, 2024 10:33
@domire8 domire8 changed the title feat!: add support for generic inputs and outputs (#141) feat!: add support for generic inputs and outputs Oct 4, 2024
@domire8 domire8 changed the title feat!: add support for generic inputs and outputs feat!: add support for custom inputs and outputs Oct 4, 2024
@domire8 domire8 force-pushed the feat/generic_pubsub_dev branch from c1c0a57 to e112b72 Compare October 4, 2024 10:36
eeberhard
eeberhard previously approved these changes Oct 4, 2024
Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work here! Looks good to me, and would be nice to have a release candidate for testing final points before committing to the 5.0.0 release. The release candidate can be made in a followup PR, in order to fast-forward these commits and keep the history clean

domire8
domire8 previously approved these changes Oct 4, 2024
Copy link
Member

@domire8 domire8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@domire8 domire8 dismissed stale reviews from eeberhard and themself via aa22a8c October 4, 2024 12:13
@domire8 domire8 force-pushed the feat/generic_pubsub_dev branch from e112b72 to aa22a8c Compare October 4, 2024 12:13
@bpapaspyros bpapaspyros merged commit ff03bf0 into main Oct 4, 2024
4 checks passed
@bpapaspyros bpapaspyros deleted the feat/generic_pubsub_dev branch October 4, 2024 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants