-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add support for custom inputs and outputs #145
Conversation
For me, this feature is now complete and we can update issue, description and changelog and then expect final reviews |
c1c0a57
to
e112b72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work here! Looks good to me, and would be nice to have a release candidate for testing final points before committing to the 5.0.0 release. The release candidate can be made in a followup PR, in order to fast-forward these commits and keep the history clean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice
e112b72
to
aa22a8c
Compare
Description
Reference the following PRs:
This PR solves the issue by providing compile-time type inference for C++ to allow for generic types to be handled properly, and similar (runtime) changes for python which mirrors the C++ version.
Review guidelines
Estimated Time of Review: 35 minutes
Checklist before merging: