-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a user, I want all registration numbers extracted with their type #30
Comments
Should we differentiate nutrients and ingredients? Also please, reminder to have a chat with @Francois-Werbrouck and @Endlessflow to agree on required updates to the analysis data format. |
does this mean every entries of Guaranteed_Analysis will look like: {
"nutrient" : "Name",
"value" : 0.0,
"unit" : false,
"registration_number" : ????
} Also what is a registration number of a Nutrient? Is there a list of all the known Nutrients and their registration number? |
@snakedye and @Endlessflow should answer this. But that should be in ingredient.
Not nutrient, but ingredient. I can ask for examples of labels with registered ingredients. But the client himself said that if an ingredient is registered, it's registration number has to be listed on the label (next to the ingredient we can assume). And this is completely different from the registration number of the fertilizer itself. As long as the information is saved, the nomenclature matters less. |
I've asked the client for further information because the information we have at the moment is confusing. I suggest we wait until developping this to get a better understanding of the needs and our solution's impact |
Additional information from the client: Registered fertilizer products list |
I think so because it just uses the registration number of the fertilizer everywhere. That or maybe add a description.
|
From my understanding of this exemple, there seems to be multiple number for each ingredients (see the blue section)? The red section is the registration number of the fertilizer @Samuelpelletier3124 Gave us another use case: I see/understand the following based on the other use case:
I also wonder if it could be beneficial to link the public table shared in the previous list with our database of ingredients. We may need to revisit the structure of those object in the DB Schema's. WDYT @k-allagbe |
I think that if linking to the public record can help with the pipeline extraction, we should seriously consider it right away. @snakedye and @Endlessflow should have a better input on this. However if it is to have more complete information in our db, this could be an entirely new feature we could present the client in our next meeting and implement in future iterations. Please explain what your vision is about the subject. |
My vision was for a more complete information relationship in our database. I for sure will bring it up with the next client meeting. I'm not 100% sure I'm following on how the pipeline extraction mixed with this public record would help? But like mentioned I will ask the client about the usage of those public record. |
The sections in blue of the previous image are not ingredient numbers but product codes. We do not manage product codes.
Yes it is the registration number of the fertilizer.
Here is the clarification provided by the client: "The number you see here is a fertilizer registration number. Let me explain. There are two scenarios. Scenario 1:
Scenario 2:
So, the registration number does not refer to any ingredient in the list identified by the blue quotes; it refers to the fertilizer as an ingredient. In the example shown in the photo below, the company simply decided to add more information than necessary. |
For now, it is not necessary to address this because we have set the idea aside. Our mandate is not to detect data but only to extract it, and using this list would not provide any new information to our data as for now. |
Can we have an exemple of scenario 2 @SamuelPelletierEvraire ? |
So there aren't any registration number for ingredients on a label. If a fertilizer is used as an ingredient for the inspected fertilizer, then it is expected to see the registration number of the used fertilizer.
I think this kinda closes the case of adding registration number in the ingredient field for now. We should circle back in our architecture to allow the newly clarified relationship. Also this is kinda false:
Yes our mandate is to extract data, but we also have the responsability of storing it in a good way based on the client needs (which includes efficient research within our record). |
Seems to be the case. I still suggest you (everyone) watch the meeting video to clear out uncertainties. Then we'll move on. |
Requirements updated. Please share your thoughts. |
Perfectly said, there might be multiple registration number
It's more where it's located (in the ingredient list or not?)? Or what it represents (this fertilizer, or an ingredient of this fertilizer) ?
Technically true, However, I have a hard time thinking of away to put this into JSON? Example #1 list of Reg Number {
...
"fertiliser_name": "Name",
"registration_number": [
{
"number": "reg number 1",
"Some classifier key": "Ingredient or Fertilizer/self"
}, {
"number": "reg number 2",
"Some classifier key": "Ingredient or Fertilizer/self"
},
... Example #2 Multiple Reg Number {
...
"fertiliser_name": "Name",
"registration_number": "Placement for Reg number representing the fertilizer analyzed"
"lot_number": "something",
"weight": [
...
"ingredients_en": [
{
"nutrient": "some ingredient",
"quantity": "some value",
"registration_number": null
},
{
"nutrient": "registered fertilizer name without a quantity",
"quantity": null,
"registration_number": "a registration number"
},
{
"nutrient": "registered fertilizer name with quantity",
"quantity": "some value",
"registration_number": "another registration number"
}
],
"ingredients_fr": [
... In my opinion we should direct ourselves toward the first exemple. It will reduce the amount of work required to implement these changes and wont "need" a classification from the model until it is ready (the classifcation could be set as a default value until we have more dataset with Registration number in the ingredients) |
A compilation of examples should help in the design. @SamuelPelletierEvraire is making sure we get those. |
Description
Context
Currently, our system extracts only one registration number (whichever it finds). This registration number may represent either the fertilizer’s registration or one of the ingredient’s registration numbers. In some cases, multiple registration numbers are listed on the label, indicating multiple registered ingredients.
Problem Statement
The client has requested that we extract all registration numbers from fertilizer labels and clearly identify whether each number represents the fertilizer or its ingredients.
Acceptance Criteria
Additional Information (Optional)
The text was updated successfully, but these errors were encountered: