Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern Length Change Issues #133

Closed
thoth-amon opened this issue Dec 7, 2024 · 2 comments
Closed

Pattern Length Change Issues #133

thoth-amon opened this issue Dec 7, 2024 · 2 comments

Comments

@thoth-amon
Copy link

On v. 0.99.16

In the pattern edit window, the reset pattern to 1 button no longer works properly. It either shrinks to some bar other than 1 or just does nothing at all.

There is also a behaviour when you manually select or type the number of bars and it is smaller than the amount of already existing bars with notes in, the notes get deleted after a warning dialog. This does not work when the Expand mode is selected.

Steps to reproduce:

1: Create two (or more) bars with notes in, with Expand mode selected.
2: Shrink to one bar

These have appeared since #128 so possibly connected.

A third issue which occurred before was with manually editing the amount of bars with double digits. The bars refresh for each digit entered. For example So if you have 16 bars and you want to shrink to 14 bars, it will first shrink it to 1 bar as you type over. If the bars are full then the dialog will pop up about losing notes. If you then click ok, instead of cancel, you will lose anything in the latter 15 bars.

@ahlstromcj
Copy link
Owner

ahlstromcj commented Dec 7, 2024 via email

ahlstromcj added a commit that referenced this issue Jan 11, 2025
This release contains a large number of updates and fixes spurred
by testing and user-reports.

Fixes for reported issues:

- Issue #128. Expanded recording and related recording issues have
  been greatly tightened, plus some follow-on issues. (See NEWS).
- Issue #133. Pattern length change issues and issues found while
  working this.  See TODO for a list of things fixed.
- Issue #134. Added dates to the release-name line from 0.99.14 on.

Other fixes:

- Fixed a segfault when clicking the Restart button with external
  live frame(s) or external song editor open.
- Fixed a seqfault when opening a new tune or a recent-file with a
  pattern-editor already up for the current tune.
- Main window. Fixed updating the PPQN when a file of different
  PPQN is loaded.

Updates:

- Majorly revamped, fixed, and tightened the "Pattern Fix" dialog.
- Added a little more control over the lines and palette of the
  various panes in the pattern and song editors. Also improved the
  appearance of time signatures other than 4/4.
- Refactored the event/buss dropdowns to be modified only when
  the user changes setting or tries to bring up the dropdowns
- Added ghost notes to the pattern-editor selection box and other
  means of note selection.
- Some minor tweaking (field size, font) of various dialogs.
- See NEWS and ChangeLog for full details.
@thoth-amon
Copy link
Author

Confirmed fixed in latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants