Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow appPath to be passed as an environment variable #614

Open
twolfson opened this issue Jan 2, 2017 · 0 comments
Open

Allow appPath to be passed as an environment variable #614

twolfson opened this issue Jan 2, 2017 · 0 comments

Comments

@twolfson
Copy link

twolfson commented Jan 2, 2017

We are using gm for image-diff, a wrapper around ImageMagick's compare functionality. We recently got an issue requesting support for appPath being passed through from our library to gm itself (uber-archive/image-diff#51).

We are open to supporting this via JS but it seems like something that could be controlled via environment variables (e.g. in Karma, we can pass browser executable paths via _BIN environmnet variables -- e.g. PHANTOMJS_BIN, FIREFOX_BIN).

We were wondering if we could add support for appPath being an environment variable (e.g. GM_APP_PATH, or maybe something less confusing so we have 1 for ImageMagick and 1 for GraphicsMagick)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant