From 5295a780b57df6d7aafa82b215614960cbcb1a98 Mon Sep 17 00:00:00 2001 From: Bane Sullivan Date: Wed, 16 Dec 2020 11:30:36 -0700 Subject: [PATCH 1/3] Create lint.yml --- .github/workflows/lint.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 .github/workflows/lint.yml diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml new file mode 100644 index 0000000..cb6f098 --- /dev/null +++ b/.github/workflows/lint.yml @@ -0,0 +1,15 @@ +on: [pull_request] + +jobs: + lint: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v1 + - uses: grantmcconnaughey/lintly-flake8-github-action@v1.0 + with: + # The GitHub API token to create reviews with + token: ${{ secrets.GITHUB_TOKEN }} + # Fail if "new" violations detected or "any", default "new" + failIf: new + # Additional arguments to pass to flake8, default "." (current directory) + args: "--ignore=E121,E123 ." From af2a48fcbcefb106202f56adace11fd6f61dd16a Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Wed, 16 Dec 2020 11:35:06 -0700 Subject: [PATCH 2/3] lint = any --- .github/workflows/lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index cb6f098..e45c94a 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -10,6 +10,6 @@ jobs: # The GitHub API token to create reviews with token: ${{ secrets.GITHUB_TOKEN }} # Fail if "new" violations detected or "any", default "new" - failIf: new + failIf: any # Additional arguments to pass to flake8, default "." (current directory) args: "--ignore=E121,E123 ." From cfbc17ef84a7bbef1b65ff88b87680188f3b74f8 Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Wed, 16 Dec 2020 11:40:44 -0700 Subject: [PATCH 3/3] breaking the linter --- agu_oss/clean_data.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/agu_oss/clean_data.py b/agu_oss/clean_data.py index be27dba..3378763 100644 --- a/agu_oss/clean_data.py +++ b/agu_oss/clean_data.py @@ -1,6 +1,7 @@ """A second sample module to clean data.""" import pandas as pd +import numpy as np def open_and_clean(url): """ @@ -20,7 +21,7 @@ def open_and_clean(url): """ temp_df = pd.read_csv(url, - skiprows=69, + skiprows = 69, delim_whitespace=True) all_cols = temp_df.columns[1:]