From e98e06d7a5855153c63934dff48a56d168511e8d Mon Sep 17 00:00:00 2001 From: Peter Makus <47005330+PeterMakus@users.noreply.github.com> Date: Wed, 16 Dec 2020 17:51:56 +0100 Subject: [PATCH 1/7] silly change --- agu_oss/clean_data.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/agu_oss/clean_data.py b/agu_oss/clean_data.py index be27dba..8988a31 100644 --- a/agu_oss/clean_data.py +++ b/agu_oss/clean_data.py @@ -34,5 +34,7 @@ def open_and_clean(url): # Finally create a date time column temp_df["date"] = pd.to_datetime(temp_df[['Year', 'Month', 'Day']]) + + print('done') return temp_df.set_index("date") From 783cf40738812ba919760ecfff401648d0621385 Mon Sep 17 00:00:00 2001 From: Peter Makus <47005330+PeterMakus@users.noreply.github.com> Date: Wed, 16 Dec 2020 19:31:35 +0100 Subject: [PATCH 2/7] Create workflowstest.yml --- .github/workflowstest.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 .github/workflowstest.yml diff --git a/.github/workflowstest.yml b/.github/workflowstest.yml new file mode 100644 index 0000000..cb6f098 --- /dev/null +++ b/.github/workflowstest.yml @@ -0,0 +1,15 @@ +on: [pull_request] + +jobs: + lint: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v1 + - uses: grantmcconnaughey/lintly-flake8-github-action@v1.0 + with: + # The GitHub API token to create reviews with + token: ${{ secrets.GITHUB_TOKEN }} + # Fail if "new" violations detected or "any", default "new" + failIf: new + # Additional arguments to pass to flake8, default "." (current directory) + args: "--ignore=E121,E123 ." From 6f795596bbec1e8233a57e1e8aee94cf0f3fcec7 Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Thu, 17 Dec 2020 08:43:41 -0700 Subject: [PATCH 3/7] mess up linting --- agu_oss/clean_data.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/agu_oss/clean_data.py b/agu_oss/clean_data.py index 8988a31..d35888f 100644 --- a/agu_oss/clean_data.py +++ b/agu_oss/clean_data.py @@ -20,7 +20,7 @@ def open_and_clean(url): """ temp_df = pd.read_csv(url, - skiprows=69, + skiprows = 69, delim_whitespace=True) all_cols = temp_df.columns[1:] From b015f79f78cf3b8e15bcc4a40ccb2776b30888bf Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Thu, 17 Dec 2020 08:44:53 -0700 Subject: [PATCH 4/7] update workflow with name and run on all files --- .github/workflowstest.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflowstest.yml b/.github/workflowstest.yml index cb6f098..063d508 100644 --- a/.github/workflowstest.yml +++ b/.github/workflowstest.yml @@ -1,3 +1,4 @@ +name: "Lint All The Things" on: [pull_request] jobs: @@ -10,6 +11,6 @@ jobs: # The GitHub API token to create reviews with token: ${{ secrets.GITHUB_TOKEN }} # Fail if "new" violations detected or "any", default "new" - failIf: new + failIf: any # Additional arguments to pass to flake8, default "." (current directory) args: "--ignore=E121,E123 ." From dc4f5c173accc0f30b3eeecdaadce8526579919e Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Thu, 17 Dec 2020 09:39:17 -0700 Subject: [PATCH 5/7] run on push too --- .github/workflowstest.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflowstest.yml b/.github/workflowstest.yml index 063d508..2220753 100644 --- a/.github/workflowstest.yml +++ b/.github/workflowstest.yml @@ -1,5 +1,5 @@ name: "Lint All The Things" -on: [pull_request] +on: [pull_request, push] jobs: lint: From 5e5c0c11183db9d40aca41e3ee820f62bb900079 Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Thu, 17 Dec 2020 09:40:18 -0700 Subject: [PATCH 6/7] another lint error --- agu_oss/clean_data.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/agu_oss/clean_data.py b/agu_oss/clean_data.py index d35888f..3ae554c 100644 --- a/agu_oss/clean_data.py +++ b/agu_oss/clean_data.py @@ -21,7 +21,7 @@ def open_and_clean(url): temp_df = pd.read_csv(url, skiprows = 69, - delim_whitespace=True) + delim_whitespace = True) all_cols = temp_df.columns[1:] From 5ef83fe1c14bf94f4749a480584756378655b5df Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Thu, 17 Dec 2020 09:42:01 -0700 Subject: [PATCH 7/7] last try --- .github/workflowstest.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflowstest.yml b/.github/workflowstest.yml index 2220753..c9e1d0d 100644 --- a/.github/workflowstest.yml +++ b/.github/workflowstest.yml @@ -1,5 +1,11 @@ -name: "Lint All The Things" -on: [pull_request, push] +name: Lint All The Things +on: + push: + branches: + - '*' + pull_request: + branches: + - '*' jobs: lint: