Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exp: regression in processing (not)in with empty list #681

Open
stariy95 opened this issue Jun 19, 2024 · 0 comments · May be fixed by #682
Open

Exp: regression in processing (not)in with empty list #681

stariy95 opened this issue Jun 19, 2024 · 0 comments · May be fixed by #682
Assignees
Milestone

Comments

@stariy95
Copy link
Member

After introducing own exp parser we broke usage of (not)in expression with an empty argument list, like in cayenneExp: {"exp":"id in $ids","params":{"ids":[]}}
Before it relied on Cayenne to optimize this to just false, now it fails with incorrect SQL generated: id in ()

There's a room for optimization on Cayenne side (see CAY-2860) but for now it should be fixed in Agrest.

@stariy95 stariy95 self-assigned this Jun 19, 2024
@stariy95 stariy95 added this to the 5.0-M20 milestone Jun 19, 2024
stariy95 added a commit to stariy95/agrest that referenced this issue Jun 19, 2024
stariy95 added a commit to stariy95/agrest that referenced this issue Jun 28, 2024
@stariy95 stariy95 modified the milestones: 5.0-M20, 5.0-M21 Sep 25, 2024
stariy95 added a commit to stariy95/agrest that referenced this issue Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant