chore: compute price change if sortedOracleDailyPrices > 2 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-inter-dashboard with
|
| Latest commit: |
d6cb18b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ae7ee4fa.agoric-inter-dashboard.pages.dev |
| Branch Preview URL: | https://rs-error-handle-token-prices.agoric-inter-dashboard.pages.dev |
|
Cloudflare deployment logs are available here |
rabi-siddique
force-pushed
the
rs-error-handle-token-prices
branch
from
9c825c1 to
db89184
Compare
frazarshad
reviewed
Jun 7, 2024
src/widgets/TokenPrices.tsx
Outdated
| @@ -38,7 +38,7 @@ export function TokenPrices({ title = 'Summary', data, isLoading }: Props) { | |||
| // Determine 24h change in oracle price | |||
| const sortedOracleDailyPrices = token?.oracleDailyPrices?.sort((a, b) => b.dateKey - a.dateKey); | |||
| const changeValue = | |||
| sortedOracleDailyPrices.length > 0 | |||
| sortedOracleDailyPrices.length > 2 | |||
There was a problem hiding this comment.
length of two would be a valid case
Suggested change
| sortedOracleDailyPrices.length > 2 | |
| sortedOracleDailyPrices.length >= 2 |
rabi-siddique
force-pushed
the
rs-error-handle-token-prices
branch
from
db89184 to
d6cb18b
Compare
frazarshad
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing locally, I encountered an error where
typeOutAmountLastwasnull, causing the UI to break. To determine the 24h price change,sortedOracleDailyPricesneeds to contain at least two objects (today's and yesterday's prices), but this was not the case.This PR addresses this edge case by ensuring we only compute the price change if
sortedOracleDailyPricescontains at least two objects.Otherwise, we reflect this in the UI:
