Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain check is ignored with blacklist set #12

Open
bobrik opened this issue Jul 30, 2015 · 1 comment
Open

Domain check is ignored with blacklist set #12

bobrik opened this issue Jul 30, 2015 · 1 comment

Comments

@bobrik
Copy link

bobrik commented Jul 30, 2015

Take a look at example:

> w = false
> b = true
> d = true
> if not w and not b and d then print("domain is checked!") end

This mimics:

  -- If no whitelist or blacklist, match on domain
  if not whitelist and not blacklist and domain then

The check should look like this: (domain or whitelist) and (not blacklist), here variables represent computed conditions for specific email.

This way you could have:

  1. Full domain and some extra people from other domains.
  2. Full domain except some people without access.
@bobrik
Copy link
Author

bobrik commented Jul 30, 2015

Whitelist checks are also ignored after user signed in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant