[ENH] KILL WITH FIRE #2037
Merged
[ENH] KILL WITH FIRE #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltsaprounis
previously approved these changes
Sep 14, 2024
TonyBagnall
dismissed stale reviews from hadifawaz1999 and ltsaprounis
via
f928076
14 tasks
MatthewMiddlehurst
previously approved these changes
Sep 17, 2024
chrisholder
reviewed
Sep 17, 2024
TonyBagnall
dismissed stale reviews from hadifawaz1999, chrisholder, and MatthewMiddlehurst
via
c0a0647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
closes #37 #42 #99 #136 #240 #265 #291 #337 #341 #1388 #1491 #1629 #1446 #1156 #1734 #217 #2015
probably #599 too
What does this implement/fix? Explain your changes.
This is the big refactor/deprecation prior to 1.0.0, aka the project internally referred to as KILL WITH FIRE.
Removes forecasting module and datatypes module and all accompanying tests/references etc. Removes operator overloading, so called vectorisation and all output conversion from BaseTransformer
To Note
BaseTransformer is linked into the interval trees, needs untangling to remove BaseTransformer completely, although we might want to keep it for tags
The registry will need some refactoring after, I'm just removing tests for now, could be the whole thing may be reworked. I think we should revisit tags