Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Add class_weight parameter to classifiers that use sklearn based estimators with testing #1777

Open
hadifawaz1999 opened this issue Jul 9, 2024 · 2 comments · May be fixed by #1798
Open

[ENH] Add class_weight parameter to classifiers that use sklearn based estimators with testing #1777

hadifawaz1999 opened this issue Jul 9, 2024 · 2 comments · May be fixed by #1798
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement testing Testing related issue or pull request

Comments

@hadifawaz1999
Copy link
Member

hadifawaz1999 commented Jul 9, 2024 •
edited
Loading

Describe the feature or idea you want to propose

following #1776

Describe your proposed solution

other classifiers need this update as well, like feature based for example
Also should add testing for this setup

Describe alternatives you've considered, if relevant

we should make sure we cover all of them

Additional context

No response
@hadifawaz1999 hadifawaz1999 added the enhancement New feature, improvement request or other non-bug code enhancement label Jul 9, 2024
@hadifawaz1999 hadifawaz1999 mentioned this issue Jul 9, 2024
Merged
@hadifawaz1999 hadifawaz1999 added classification Classification package testing Testing related issue or pull request labels Jul 9, 2024
@hadifawaz1999 hadifawaz1999 changed the title [ENH] Add class_weight parameter to classifiers that use sklearn based estimators [ENH] Add class_weight parameter to classifiers that use sklearn based estimators with testing Jul 9, 2024
@harshithasudhakar harshithasudhakar linked a pull request Jul 14, 2024 that will close this issue
Draft
1 task
@TonyBagnall
Copy link
Contributor

hi @hadifawaz1999 is this issue resolved, or, if not, a list of classifiers effected would be useful.

@hadifawaz1999
Copy link
Member Author

hi @hadifawaz1999 is this issue resolved, or, if not, a list of classifiers effected would be useful.

no idea if it was resolved would need to check some classifiers still missing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement testing Testing related issue or pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ENH] Add class_weight parameter to REDCOMETS harshithasudhakar/aeon
2 participants
@TonyBagnall @hadifawaz1999