Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orefs.py doesn't convert ref without verses and range of chapters #73

Open
LAfricain opened this issue Jan 9, 2019 · 5 comments
Open

Comments

@LAfricain
Copy link

First case when orefs doesn't convert to an osis ref a book name with only a chapter:
Ex: Mez.53 (Ps 53) this psalm is the same as the 14, maybe if we have this case we can propose to convert it to Ps 53 v. 1?
Second case rage of chapters as : 22-24, The problem is the same. maybe convert it to book 22 v.1?

@DavidHaslam
Copy link

Great questions.

@adyeths
Copy link
Owner

adyeths commented Jan 11, 2019

Handling references without verse numbers is not something I have implemented in orefs yet.

@DavidHaslam
Copy link

I suppose by suggesting the osisRef should be just to first verse, we’re trying avoid a scenario where the Xiphos preview pane could suddenly be filled with all 176 verses of Psalm 119, simply because there’s a note that references the Psalm as a location.

@DavidHaslam
Copy link

@LAfricain
Just to make it clear what was the context.

Psalm 53 has almost the same wording as Psalm 14.

@LAfricain LAfricain changed the title orefs.py doesn't convert ref without verses an range of chapters orefs.py doesn't convert ref without verses and range of chapters Jan 21, 2019
@LAfricain
Copy link
Author

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants