From 28777edd6fd6e956cac1febf8591b8b4dc98bbcc Mon Sep 17 00:00:00 2001 From: Jason Sznol Date: Mon, 3 Apr 2023 17:22:35 -0400 Subject: [PATCH] Fixed Kotlin deploy to AWS (#137) --- kotlin/build.gradle.kts | 4 +++- .../kotlin/com/adsbynimbus/openrtb/response/BidResponse.kt | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/kotlin/build.gradle.kts b/kotlin/build.gradle.kts index abb0cb5..cf5eecb 100644 --- a/kotlin/build.gradle.kts +++ b/kotlin/build.gradle.kts @@ -128,7 +128,9 @@ publishing { maven { name = "aws" setUrl("s3://adsbynimbus-public/android/sdks") - credentials(AwsCredentials::class) + authentication { + create("awsIm") + } } providers.environmentVariable("GITHUB_REPOSITORY").orNull?.let { maven { diff --git a/kotlin/src/commonMain/kotlin/com/adsbynimbus/openrtb/response/BidResponse.kt b/kotlin/src/commonMain/kotlin/com/adsbynimbus/openrtb/response/BidResponse.kt index a3fd4e9..ce36127 100644 --- a/kotlin/src/commonMain/kotlin/com/adsbynimbus/openrtb/response/BidResponse.kt +++ b/kotlin/src/commonMain/kotlin/com/adsbynimbus/openrtb/response/BidResponse.kt @@ -58,9 +58,9 @@ public class BidResponse( public val impression_trackers: Array? get() = trackers["impression_trackers"] /** Urls to fire a request to when a click is registered */ public val click_trackers: Array? get() = trackers["click_trackers"] - /** Url to fire a request to when an there's an auction win */ + /** Url to fire a request to when this bid wins an auction */ public val win_response: String? get() = external_notifications["win_response"] - /** Url to fire a request to when an there's an auction loss */ + /** Url to fire a request to when this bid loses an auction */ public val loss_response: String? get() = external_notifications["loss_response"] public companion object {