forked from model-checking/kani
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix ICE due to mishandling of Aggregate rvalue for raw pointers to `s…
…tr` (model-checking#3448) We were missing a match arm for the case where a raw pointer to a string slice was created from a thin pointer and the string size. Resolves model-checking#3312 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
- Loading branch information
Showing
5 changed files
with
56 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// Copyright Kani Contributors | ||
// SPDX-License-Identifier: Apache-2.0 OR MIT | ||
//! Checks that Kani can handle creating pointers for slices from raw parts. | ||
//! This used to trigger an ICE reported in <https://github.com/model-checking/kani/issues/3312>. | ||
#![feature(ptr_metadata)] | ||
|
||
#[derive(kani::Arbitrary)] | ||
struct AscII { | ||
#[safety_constraint(*inner < 128)] | ||
inner: u8, | ||
} | ||
|
||
#[kani::proof] | ||
fn check_from_raw() { | ||
let ascii: [AscII; 5] = kani::any(); | ||
let slice_ptr: *const [AscII] = &ascii; | ||
let (ptr, metadata) = slice_ptr.to_raw_parts(); | ||
let str_ptr: *const str = std::ptr::from_raw_parts(ptr, metadata); | ||
assert!(unsafe { (&*str_ptr).is_ascii() }); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# Copyright Kani Contributors | ||
# SPDX-License-Identifier: Apache-2.0 OR MIT | ||
|
||
[package] | ||
name = "check_smol_str" | ||
version = "0.1.0" | ||
edition = "2021" | ||
|
||
[dependencies] | ||
# Make dependency fixed to ensure the test stays the same. | ||
smol_str = "=0.2.2" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Checking harness check_new... | ||
VERIFICATION:- SUCCESSFUL | ||
|
||
Complete - 1 successfully verified harnesses, 0 failures, 1 total. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
// Copyright Kani Contributors | ||
// SPDX-License-Identifier: Apache-2.0 OR MIT | ||
//! Test that Kani can correctly verify the cedar implementation of `SmolStr` | ||
//! An ICE was initially reported for this case in: | ||
//! <https://github.com/model-checking/kani/issues/3312> | ||
#[kani::proof] | ||
#[kani::unwind(4)] | ||
fn check_new() { | ||
let data: [char; 3] = kani::any(); | ||
let input: String = data.iter().collect(); | ||
smol_str::SmolStr::new(&input); | ||
} |