Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Repository release branches don't have mandatory PR review #4045

Closed
adamfarley opened this issue Nov 18, 2024 · 1 comment · Fixed by adoptium/.eclipsefdn#70
Closed

Bug: Repository release branches don't have mandatory PR review #4045

adamfarley opened this issue Nov 18, 2024 · 1 comment · Fixed by adoptium/.eclipsefdn#70
Assignees
@andrew-m-leonard
Labels
tech-debt Issues that aim to fix problems caused by previous changes to the repo

Comments

@adamfarley
Copy link
Contributor

Summary

Build repo release branches should have a mandatory PR review, and don't.

Observed behaviour:

Build repository release branches don't have a mandatory PR review.

This is probably because the settings regex does not match.

Any other comments:

Original comment:

adoptium/temurin#54 (comment)

Put in backlog, assign to Andrew (tech debt - critical)
@adamfarley adamfarley added the tech-debt Issues that aim to fix problems caused by previous changes to the repo label Nov 18, 2024
@adamfarley adamfarley mentioned this issue Nov 18, 2024
Closed
8 tasks
@andrew-m-leonard andrew-m-leonard moved this to In Progress in 2024 4Q Adoptium Plan Nov 19, 2024
@andrew-m-leonard
Copy link
Contributor

andrew-m-leonard commented Nov 19, 2024 •
edited by adamfarley
Loading

Otterdog pattern for branch selection: https://ruby-doc.org/core-2.5.1/File.html#method-c-fnmatch

@andrew-m-leonard andrew-m-leonard mentioned this issue Nov 19, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in 2024 4Q Adoptium Plan Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-m-leonard andrew-m-leonard

Labels
tech-debt Issues that aim to fix problems caused by previous changes to the repo
Projects
2024 4Q Adoptium Plan
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set release branch protection with approve reviews 2 andrew-m-leonard/.eclipsefdn
2 participants
@adamfarley @andrew-m-leonard