Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask RPM for its own arch instead of objdump hacks #567

Merged
merged 1 commit into from
May 30, 2024

Conversation

gdams
Copy link
Member

@gdams gdams commented May 29, 2024

Applies the same fix described here: docker-library/openjdk#537

Copy link
Contributor

@tellison tellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that it removes amd64 i386 recognition, which was strange to have as a couple anyway?

@gdams gdams merged commit 537b2ce into adoptium:main May 30, 2024
73 checks passed
@gdams gdams deleted the objdump branch May 30, 2024 13:11
@tianon
Copy link

tianon commented May 31, 2024

Noting that it removes amd64 i386 recognition, which was strange to have as a couple anyway?

That coupling is the raw output from objdump which represents amd64:

$ docker run --rm openjdk:23-oracle objdump --file-headers /usr/bin/objdump | grep architecture
architecture: i386:x86-64, flags 0x00000150:

(so it's not "lost" so much as replaced by the "x86_64" value returned from rpm instead)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants