Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --init to docker run commands in builds to prevent excessive resource consumption #1067

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

@sxa sxa self-assigned this Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@sxa sxa changed the title Dockerbuild init add --init to docker run commands in builds to prevent excessive resource consumption Jul 3, 2024
@sxa sxa force-pushed the dockerbuild_init branch from a3bde27 to 32730e9 Compare July 3, 2024 11:51
@github-actions github-actions bot added the docker label Jul 3, 2024
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karianna
Copy link
Contributor

karianna commented Jul 4, 2024

@sxa If your tests were good please go ahead and merge!

@sxa sxa merged commit 9c2c790 into adoptium:master Jul 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defunct processes in docker containers chewing up resources during builds
3 participants