Changing JCK HTTP URL #5779
Merged
Changing JCK HTTP URL #5779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For details, see https://github.com/temurin-compliance/ temurin-compliance/issues/589 Signed-off-by: Adam Farley <[email protected]>
|
Please assign this to me, thank you. |
|
Running tests now. Will update when finished. |
Signed-off-by: Adam Farley <[email protected]>
|
Update: The URL change has the correct effect, except for in 2 places. The Amended URL appears to have the appropriate effect in all scenarios. |
smlambert
approved these changes
Nov 27, 2024
sophia-guo
approved these changes
Nov 27, 2024
|
@adamfarley So it's not safe to merge this I assume? |
|
It's fine to merge. |
|
Thank you @smlambert and @sophia-guo Also @karianna, for your concern. 🤓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details, see https://github.com/temurin-compliance/ temurin-compliance/issues/589