Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change generated core files current dir to reportdir #5389

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

sophiaxu0424
Copy link
Contributor

This is to change the directory of core files to the correct one

Related to issue: #5373

Signed-off-by: sophiaxu0424 [email protected]

@sophiaxu0424 sophiaxu0424 changed the title Change generated core files des to reportdir Change generated core files current dir to reportdir Jun 13, 2024
@sophiaxu0424
Copy link
Contributor Author

Grinder Test: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41379/consoleFull
Ran into a failure in running Target: openJcePlusTests
But the path changes was working fine, was able to processing with the test, the concern is that it can't not find the key words in below (might be the reason that the console log size is too large to identify):

JIT dump written to /home/jenkins/workspace xxxx 

But please let me know if we need to run other target tests as well.

@sophiaxu0424
Copy link
Contributor Author

@LongyuZhang would you please kind review, thanks

@sophiaxu0424 sophiaxu0424 marked this pull request as ready for review June 18, 2024 14:20
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose for this PR is able to archive the dump file. To test the PR:

  • rerun the original build to reproduce the dump process
  • change to your branch to see if dump process can still be generated (checkbox Keep_Workspace and Keep_ReportDir so you can reserve the machine to go back and check), then check if the core file is saved in the target folder as expected.
  • If the core file is saved in the target folder, I suppose it will be uploaded into the build artifactory automatically.

@sophiaxu0424
Copy link
Contributor Author

sophiaxu0424 commented Jun 18, 2024

After this changes, the JIT dump files are now collected under path (see below), Please refer to this Grinder test: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41449/consoleFull.

16:18:53       [test]     [junit] JVMDUMP010I JIT dump written to /home/jenkins/workspace/Grinder/jvmtest/functional/OpenJcePlusTests/jitdump.20240618.211835.533083.0004.dmp
Screenshot 2024-06-18 at 4 23 40 PM

This is not the desired reportdir we wanted. see below comment..

@sophiaxu0424 sophiaxu0424 force-pushed the issue5373 branch 9 times, most recently from a3b9447 to 799e0c5 Compare June 20, 2024 14:07
@sophiaxu0424
Copy link
Contributor Author

Running parallelly on 5 machines, and one machine has the dump core files generated now:

13:34:21       [test]     [junit] JVMDUMP039I Processing dump event "gpf", detail "" at 2024/06/20 17:34:21 - please wait.
13:34:21       [test]     [junit] JVMDUMP032I JVM requested System dump using '/home/jenkins/workspace/Grinder_iteration_3/aqa-tests/TKG/output_17189048276599/openJcePlusTests_0/core.20240620.173421.3463332.0003.dmp' in response to an event
13:34:22       [test]     [junit] JVMDUMP010I System dump written to /home/jenkins/workspace/Grinder_iteration_3/aqa-tests/TKG/output_17189048276599/openJcePlusTests_0/core.20240620.173421.3463332.0003.dmp
13:34:22       [test]     [junit] JVMDUMP032I JVM requested Java dump using '/home/jenkins/workspace/Grinder_iteration_3/aqa-tests/TKG/output_17189048276599/openJcePlusTests_0/javacore.20240620.173421.3463332.0004.txt' in response to an event
13:34:22       [test]     [junit] JVMDUMP012E Error in Java dump: /home/jenkins/workspace/Grinder_iteration_3/aqa-tests/TKG/output_17189048276599/openJcePlusTests_0/javacore.20240620.173421.3463332.0004.txt
13:34:22       [test]     [junit] JVMDUMP032I JVM requested Snap dump using '/home/jenkins/workspace/Grinder_iteration_3/aqa-tests/TKG/output_17189048276599/openJcePlusTests_0/Snap.20240620.173421.3463332.0005.trc' in response to an event
13:34:22       [test]     [junit] JVMDUMP010I Snap dump written to /home/jenkins/workspace/Grinder_iteration_3/aqa-tests/TKG/output_17189048276599/openJcePlusTests_0/Snap.20240620.173421.3463332.0005.trc
13:34:22       [test]     [junit] JVMDUMP032I JVM requested JIT dump using '/home/jenkins/workspace/Grinder_iteration_3/aqa-tests/TKG/output_17189048276599/openJcePlusTests_0/jitdump.20240620.173421.3463332.0006.dmp' in response to an event
13:34:22       [test]     [junit] JVMDUMP051I JIT dump occurred in 'GC Worker' thread 0x000000000025E700
13:34:22       [test]     [junit] JVMDUMP010I JIT dump written to /home/jenkins/workspace/Grinder_iteration_3/aqa-tests/TKG/output_17189048276599/openJcePlusTests_0/jitdump.20240620.173421.3463332.0006.dmp

@sophiaxu0424
Copy link
Contributor Author

sophiaxu0424 commented Jun 20, 2024

The dump core files are generated in the folder, pls check:
Screenshot 2024-06-20 at 2 35 19 PM

@sophiaxu0424 sophiaxu0424 requested a review from LongyuZhang June 20, 2024 18:41
This is to change the directory of core files to the correct one

Related to issue: adoptium#5373

Signed-off-by: sophiaxu0424 <[email protected]>
@sophiaxu0424
Copy link
Contributor Author

Verified that the with the latest change, the parent and child tests could also generate dump files in the correct reportdir, and checked artifactory as well:

17:20:25       [test]     [junit] JVMDUMP010I System dump written to /home/jenkins/workspace/Grinder_iteration_2/aqa-tests/TKG/output_17189183329023/openJcePlusTests_0/core.20240620.142023.10214.0001.dmp

@LongyuZhang LongyuZhang requested a review from smlambert June 21, 2024 03:35
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants