Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude SharedClasse softmx increase JitAot test from linux ppc64le #285

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Exclude SharedClasse softmx increase JitAot test from linux ppc64le #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions systemtest/playlist.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,7 @@
</impls>
</test>

<!-- Exclude the following test on Linux ppc64le. Reason: AdoptOpenJDK/openjdk-systemtest/issues/79 -->
<test>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the < disabled > tag

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shelley, the test is only failing on ppc64le Linux. So, it's only excluded from running on that platform. This is achieved by the use of platformRequirements tag.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so the original test has been repurposed as the non-linux one, and a new test added for the linux platforms with ^ppcle for now.

Eventually when the defect is fixed, we drop back to only one entry for that test in the playlist (for all platforms).

This change could have been done with only one test entry, by just adding ^ppcle to the list? or you would then have to explicitly mention all platforms it could run on?

Copy link
Contributor Author

@Mesbah-Alam Mesbah-Alam Feb 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if we just added ^ppc in the single test entry, then that'd exclude the test from ppc64 aix too, so in that case we would have had to explicitly mention each platform it runs on. Yes, once the test is fixed, we will remove the second entry of the test and also remove the platformRequirements tag from the first entry.

<testCaseName>SharedClassesWorkloadTest_Softmx_Increase_JitAot</testCaseName>
<variations>
Expand All @@ -721,6 +722,36 @@
<impls>
<impl>openj9</impl>
</impls>
<platformRequirements>^os.linux</platformRequirements>
</test>

<test>
<testCaseName>SharedClassesWorkloadTest_Softmx_Increase_JitAot_Linux</testCaseName>
<variations>
<variation>NoOptions</variation>
</variations>
<command>export JAVA_HOME=$(JDK_HOME)$(D) && \
perl $(TEST_RESROOT)$(D)stf$(D)stf.core$(D)scripts$(D)stf.pl \
-test-root=$(Q)$(TEST_RESROOT)$(D)stf;$(TEST_RESROOT)$(D)openjdk-systemtest;$(TEST_RESROOT)$(D)openj9-systemtest$(Q) \
-systemtest-prereqs=$(Q)$(TEST_RESROOT)$(D)systemtest_prereqs$(Q) \
-results-root=$(REPORTDIR) \
-test=SharedClassesWorkloadTest_Softmx_Increase_JitAot; \
$(TEST_STATUS)</command>
<subsets>
<subset>SE80</subset>
<subset>SE90</subset>
<subset>SE100</subset>
</subsets>
<levels>
<level>extended</level>
</levels>
<groups>
<group>system</group>
</groups>
<impls>
<impl>openj9</impl>
</impls>
<platformRequirements>os.linux,^arch.ppc</platformRequirements>
</test>

<test>
Expand Down