-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MockitoTest's build.xml to use the same jdk version as to playlist.xml #5359
Conversation
sophiaxu0424
commented
May 30, 2024
- Issue to Tests failing in containerised arm32 environments JDK8 infrastructure#3043
Signed-off-by: sophiaxu0424 <[email protected]>
Signed-off-by: sophiaxu0424 <[email protected]>
c749a23
to
ff55fe9
Compare
Signed-off-by: sophiaxu0424 <[email protected]>
424b497
to
a13d16b
Compare
Running with nightly jdk11, and it passed:
|
…+ as well Signed-off-by: sophiaxu0424 <[email protected]>
Trying to testing on jdk8, but both failed with origin master branch, and this PR branch, expected SKIPPED, but keeps failing. Testing with this PR issue3043 branch, nightly jdk8 |
@llxia @LongyuZhang Would you please kindly check and see if other test should be prepared? TIA! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this PR is to fix JDK8 build failure, the grinder test needs to run with JDK8 other tests (reproduce what caused failure in the origin issue) to prove this change fixed it.
Hi Longyu, The original mockito test case with jdk11+ limitations, has compile failure and can't be skipped. I am wondering that maybe we should add this jdk8 to disabled list to avoid this compile failure? please advice as well. thanks! |
@sophiaxu0424 To validate this changes fixed the JDK8 problem, you can run your branch in a grinder with
|
Thanks Longyu, the required floatSanityTests on jdk8 has passed: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41093/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM