Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modularity tests based on Java 11 #150

Closed
Mesbah-Alam opened this issue Jul 26, 2018 · 4 comments
Closed

Update modularity tests based on Java 11 #150

Mesbah-Alam opened this issue Jul 26, 2018 · 4 comments
Assignees
Labels

Comments

@Mesbah-Alam
Copy link
Contributor

java.transaction module, on which implementation of several modularity tests depend, have been completely removed in Java 11 as part of eclipse-openj9/openj9#992

Modules removed in java 11:

java.xml.ws (JAX-WS, plus the related technologies SAAJ and Web Services Metadata)
   java.xml.bind (JAXB)
   java.activation (JAF)
   java.xml.ws.annotation (Common Annotations)
   java.corba (CORBA)
   java.transaction (JTA)

   java.se.ee (Aggregator module for the six modules above)
   jdk.xml.ws (Tools for JAX-WS)
   jdk.xml.bind (Tools for JAXB

Following tests need to be rewritten, as they depend on java.transaction:

1) /openjdk.test.modularity/src/tests/com.test/net/adoptopenjdk/test/modularity/junit/TestStressLayers.java
2) /openjdk.test.modularity/src/com.stf/net/adoptopenjdk/test/modularity/PatchModuleImageTest.java
3) /openjdk.test.modularity/src/com.stf/net/adoptopenjdk/test/modularity/PatchModuleTest.java
4) /openjdk.test.modularity/src/com.stf/net/adoptopenjdk/test/modularity/UpgradeModPathTest.java
@Mesbah-Alam
Copy link
Contributor Author

Mesbah-Alam commented Nov 26, 2018

There is no "ugradable" platform module in JDK11. As suggested in : http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-September/009310.html - the only "upgradable" platform modules have been the ones related to EE -- which have been removed. Note, java.jnlp was upgradable, but - this has also been removed from jdk11.

So, we should remove the obsolete tests - e.g., tests that involve upgrading an "upgradable" platform module.

@Mesbah-Alam
Copy link
Contributor Author

Note the patch module tests still can patch "platform modules" for which we'd have to add a replacement for the deleted java.transaction module , e.g. java.xml to be used by test for patching.

@Mesbah-Alam
Copy link
Contributor Author

Note: jlink has been updated too in jdk11, it no longer has an option called --class-for-name , the jlink related tests need to be update for this: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/460/tapResults/

@Mesbah-Alam
Copy link
Contributor Author

Mesbah-Alam commented Nov 27, 2018

This PR contains the changes required to get modularity tests running on JDK11 : #196

Change summary

  1. Removed reference to java.transaction module from all tests (as this module no longer exists in JDK11) and replaced them with java.xml.
  2. Upgrade module path related tests have been updated to exclude tests for "upgrading an upgradale system/platform module -- as the only "upradale" platform modules were ee modules (java.transaction) which have been removed in jdk11.
  3. Updated CpMpJink test and removed use of --class-for-name (this option is no longer supported in jdk11).
  4. Updated TestJDKInternalAPI test and removed reference to sun.reflect.Reflection as it no longer exists in JDK11.
  5. Removed exclusion of modularity project from system test project build list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants