Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No AQACert.log and SHA.txt content on windows #363

Closed
llxia opened this issue Oct 25, 2022 · 3 comments · Fixed by #646
Closed

No AQACert.log and SHA.txt content on windows #363

llxia opened this issue Oct 25, 2022 · 3 comments · Fixed by #646
Assignees
Labels
bug Something isn't working

Comments

@llxia
Copy link
Contributor

llxia commented Oct 25, 2022

There is no AQACert.log and SHA.txt content in TAP file on windows:
https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_sanity.functional_x86-64_windows/
https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_sanity.functional_x86-64_windows/lastSuccessfulBuild/artifact/aqa-tests/TKG/output_16658700363494/Test_openjdk11_j9_sanity.functional_x86-64_windows.tap/*view*/

# AQACert.log content: 
# 
#SHA.txt content: 
# 
# Timestamp: Sun Oct 16 00:32:19 2022 UTC 
1..358
ok 1 - cmdLineTester_bootstrapMethodArgumentTest_0 
  ---
    duration_ms: 4553
  ...
ok 2 - cmdLineTester_callsitedbgddrext_openj9_0 
  ---
    duration_ms: 87664
...

The expected behaviour would be that we would see the same type of information as retrieved during a run on a Linux or Mac platform (see TAP file from recent run on Linux)

#SHA.txt content: 
# ================================================
# timestamp: 20241129-143946
# repo dir: /home/jenkins/workspace/Grinder/aqa-tests
# git repo: 
#   Fetch URL: https://github.com/adoptium/aqa-tests.git
# sha:
# a7f0676ca19bf949745b8dc2964c52dcef4df9a2
# ================================================
# timestamp: 20241129-143946
# repo dir: /home/jenkins/workspace/Grinder/aqa-tests/TKG
# git repo: 
#   Fetch URL: https://github.com/AdoptOpenJDK/TKG.git
# sha:
# 4ab5104cbc97d54ce0deb26c9d69e4380a796922
# ================================================
# timestamp: 20241129-143952
# repo dir: /home/jenkins/workspace/Grinder/aqa-tests/openj9
# git repo: 
#   Fetch URL: https://github.com/eclipse/openj9.git
# sha:
# 9049e87fa8ee536e41916450e43760bcb4420ffe
# 
# Timestamp: Fri Nov 29 20:40:55 2024 UTC 
# TEST TARGETS RESULTS SUMMARY: TOTAL: 6   EXECUTED: 5   PASSED: 5   FAILED: 0   DISABLED: 1   SKIPPED: 0

Rerunning that same test on Windows produces this TAP output

# AQACert.log content: 
# 
# Hostname: test-azure-win-2

#SHA.txt content: 
# 
# Timestamp: Fri Nov 29 20:42:25 2024 UTC 
# TEST TARGETS RESULTS SUMMARY: TOTAL: 6   EXECUTED: 4   PASSED: 4   FAILED: 0   DISABLED: 2   SKIPPED: 0
@chandrashritii
Copy link
Contributor

Hey @smlambert @llxia I'd like to take this up. Can you please assign this issue to me?

@smlambert
Copy link
Contributor

Adding note from Slack conversation with Toshitaka Ogata:

This information is obtained via cat command in resultsSum.pl. (

my $AQACertContent = `cat $AQACert`;
)
On Windows, the operand of the cat command contains unescaped backslashes, such as /path_to_aqatests/TKG\output../AQACert.log, which seems to cause this problem. I think, escaping backslashes or replacing them with slashes would solve this issue.

@smlambert
Copy link
Contributor

smlambert commented Nov 30, 2024

Seems to be a missing / between TKG and output_xxxtimestampxxx folder

15:42:26  cat: 'C:/jenkins/workspace/Grinder/aqa-tests/TKGoutput_17329129243908../AQACert.log': No such file or directory
15:42:26  cat: 'C:/jenkins/workspace/Grinder/aqa-tests/TKGoutput_17329129243908../SHA.txt': No such file or directory
15:42:25  perl "resultsSum.pl" --failuremk="C:/jenkins/workspace/Grinder/aqa-tests/\\TKG\\failedtargets.mk" --resultFile="C:/jenkins/workspace/Grinder/aqa-tests/\\TKG\\output_17329129243908\\TestTargetResult" --platFile="C:/jenkins/workspace/Grinder/aqa-tests/\\TKG\\resources\\buildPlatformMap.properties" --diagnostic=failure --jdkVersion=11 --jdkImpl=hotspot --jdkVendor="eclipse" --spec=win_x86-64 --buildList=functional --customTarget="" --testTarget=sanity.functional --tapPath=C:/jenkins/workspace/Grinder/aqa-tests/\\TKG\\output_17329129243908\\ --tapName=Grinder_20241129204054.tap --comment=""

Look to see how tapPath is built, tacking 2 paths together, one that has slashes adjusted, one that does not

--tapPath=C:/jenkins/workspace/Grinder/aqa-tests/\\TKG\\output_17329129243908\\

@smlambert smlambert self-assigned this Dec 3, 2024
@smlambert smlambert moved this from Todo to In Progress in Adoptium Backlog Dec 3, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Adoptium Backlog Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants